Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite command parsing/serialization #231

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Rewrite command parsing/serialization #231

merged 14 commits into from
Nov 10, 2023

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Nov 7, 2023 •
edited
Loading

This PR addresses a few code quality issues with the radio library:

  • The payload length is computed by hand for each frame that requires it.
  • Parameter names are missing for both requests and responses.
  • Device states aren't logged accurately.
  • The "free slots" flag is ignored.
  • Sequence numbers alone aren't enough to match responses to requests and results in spurious bad request/response matching.

Unit tests are broken but backup, restore, permit, and energy-scan all work on a real Conbee II.

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3c82aed) 97.95% compared to head (a14912d) 98.76%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #231      +/-   ##
==========================================
+ Coverage   97.95%   98.76%   +0.81%     
==========================================
  Files           6        7       +1     
  Lines        1025      894     -131     
==========================================
- Hits         1004      883     -121     
+ Misses         21       11      -10
Files Coverage Δ
zigpy_deconz/types.py 100.00% <100.00%> (ø)
zigpy_deconz/uart.py 100.00% <100.00%> (ø)
zigpy_deconz/utils.py 100.00% <100.00%> (ø)
zigpy_deconz/api.py 98.73% <99.45%> (+3.44%) ⬆️
zigpy_deconz/zigbee/application.py 97.86% <89.28%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly mentioned this pull request Nov 10, 2023
Merged
@puddly puddly marked this pull request as ready for review November 10, 2023 16:42
@puddly puddly merged commit 7264e6a into zigpy:dev Nov 10, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@puddly